Changed $port param to $url, for more flexible configuration Added read/write timeout options, because client/status hang if service not running. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added read/write timeout options, because client/status hang if service not running.
|
I think this makes sense. I have literally only just noticed your PR! This is the downside of having over zealous email filters. I shall review! |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you for your wonderful work! It saved me a lot of time and nerves :)
I propose you to review my pull request with changes i think they will be usefull for you and others.
I found that when only port allowed to configure, its not very good because server bind itself to all IP`s by default wich is not good on prod servers because service become public.
Also by default only tcp is used wich not allow me use other transports.
Other small trouble was that when service not running status and client hangs.
I fixed this by adding timeouts.
Please review my changes and i hope they will be usefull.
Thank you.
V.