Add egg support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to using ``distutils.dir_util`` instead of ``shutil`` to remove directories since it has nice support for dry run already.
Switched from enumerating ``self.distribution.commands`` to using ``self.distribution.get_command_list``. The former is the list of command names that will be run and the latter is the list of all known commands. This will make the code work when you do not include something like ``sdist`` in the same command list.
Might as well make use of the extension here as well. This makes it much easier to test some of the trickier stuff like setting the egg base directory via the egg_info command in the setup configuration file.
dave-shawley
pushed a commit
that referenced
this pull request
May 6, 2019
catch my fork up with ionel's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--eggsparameter that removes .egg-info directories created when a package is installed locally or an egg is hatched. It also removes any .egg directories/files in the current directory. These will exist for things that are installed viasetup_requiresortests_requirekeyword parameters tosetup.