Fixed Width/Height attrs for percentage values #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this code: <iframe src="https://www.youtube.com/embed/Cq2LcFozaPg?rel=0" width="100%" height="396" frameborder="0" allowfullscreen="allowfullscreen"></iframe>
|
@aliaghdam Thanks for this. I thought we solved this in #114 & #116, so @kenhowardpdx and I might have to brainstorm a bit on what to do and what's going wrong. Might even have to write tests! AhhhHhhHH! This is also maybe in direct competition to #223 which wants to remove/modify this line entirely. All that is to say, thanks for this and gonna make sure we do it correctly this time around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iFrame with percentage width/height values will be breaked because it converts values to int
<iframe src="https://www.youtube.com/embed/Cq2LcFozaPg?rel=0" width="100%" height="396" frameborder="0" allowfullscreen="allowfullscreen"></iframe>