Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo autoplay duplicates audio in IE11 #149

Closed
Tankzor opened this issue Dec 8, 2013 · 6 comments
Closed

Vimeo autoplay duplicates audio in IE11 #149

Tankzor opened this issue Dec 8, 2013 · 6 comments

Comments

@Tankzor
Copy link

Tankzor commented Dec 8, 2013

Weird(?) one here...

If a vimeo video is set to autoplay, and the iframe has allowfullscreen="true", fitVids will cause the audio of the video to be duplicated.

Looks to be from jQuery.wrap() on line 68.

The whole video may be duplicated but just detached from the DOM? Not sure.
Only an issue in IE11.

Simple example: http://www.tests.massivedev.com/vimeo/

I've taken to wrapping iframes manually, and have removed the wrap() call (and the check for the existing container on line 60).

@davatron5000
Copy link
Owner

If you upgrade from 1.7.2 to the latest jQuery does the problem still exist? There was some work around jQuery 1.9 that changed how iframe wrapping works for IE. Ref. #26

@Tankzor
Copy link
Author

Tankzor commented Dec 8, 2013

Still occurs with 2.0.3, updated example.

@davatron5000
Copy link
Owner

It appears that FitVids is not compatible then with Vimeo Autoplay. Most of what FitVids does is automate the wrapping of videos, so if autoplay is breaking the wrapping functionality in IE11, we can't fix IE11.

  • Add note on the readme about Vimeo Autoplay incompatibility.

@Tankzor
Copy link
Author

Tankzor commented Dec 13, 2013

Cheers and thanks

jkenlooper pushed a commit to jkenlooper/FitVids.js that referenced this issue Feb 14, 2014
* davatron5000/master:
  Adding note about Vimeo Autoplay API in IE11. Closes davatron5000#149
  Updating version number re: davatron5000#137
  Contributing and issue requirements
  readme
  zepto in readme and such
  Fixing missing semicolon, removing minified file
  Taking out line breaks so the code will minify properly
  Use with jQuery or Zepto

Conflicts:
	jquery.fitvids.js
@davekiss
Copy link

Running into this issue on my end, can either of you describe the "wrap manually" process? I'm retrieving my videos onclick via the Vimeo oembed api and don't have the html available on pageload.

@davatron5000
Copy link
Owner

http://alistapart.com/article/creating-intrinsic-ratios-for-video

Here's the article FitVids is based on. You basically need to some HTML:

<div class="video-wrapper">
  <iframe></iframe>
</div>

And some CSS

.video-wrapper {
  position: relative;
  height: 0;
  padding-bottom: 56.25%; /* 16:9 Aspect Ratio */
}

.video-wrapper iframe {
  position: absolute;
  top: 0;
  left: 0;
  width: 100%;
  height: 100%;
}

FitVids just automates the aspect ratio for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants