-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vimeo autoplay duplicates audio in IE11 #149
Comments
If you upgrade from |
Still occurs with 2.0.3, updated example. |
It appears that FitVids is not compatible then with Vimeo Autoplay. Most of what FitVids does is automate the wrapping of videos, so if autoplay is breaking the wrapping functionality in IE11, we can't fix IE11.
|
Cheers and thanks |
* davatron5000/master: Adding note about Vimeo Autoplay API in IE11. Closes davatron5000#149 Updating version number re: davatron5000#137 Contributing and issue requirements readme zepto in readme and such Fixing missing semicolon, removing minified file Taking out line breaks so the code will minify properly Use with jQuery or Zepto Conflicts: jquery.fitvids.js
Running into this issue on my end, can either of you describe the "wrap manually" process? I'm retrieving my videos onclick via the Vimeo oembed api and don't have the html available on pageload. |
http://alistapart.com/article/creating-intrinsic-ratios-for-video Here's the article FitVids is based on. You basically need to some HTML:
And some CSS
FitVids just automates the aspect ratio for you. |
Weird(?) one here...
If a vimeo video is set to autoplay, and the iframe has allowfullscreen="true", fitVids will cause the audio of the video to be duplicated.
Looks to be from jQuery.wrap() on line 68.
The whole video may be duplicated but just detached from the DOM? Not sure.
Only an issue in IE11.
Simple example: http://www.tests.massivedev.com/vimeo/
I've taken to wrapping iframes manually, and have removed the wrap() call (and the check for the existing container on line 60).
The text was updated successfully, but these errors were encountered: