Add cursor property

[TonCherAmi]

This pull request adds a new theme property cursor that allows specifying the type of mouse cursor that is set when the widget is hovered. It can be set to either default, pointer, or text:

• default is the default arrow cursor
• pointer could be used for clickable areas:
  
• text could be used for input fields:
  

[codecov-commenter]

Codecov Report

Merging #1313 (9e9dd6d) into next (04c006a) will increase coverage by 0.07%.
The diff coverage is 43.18%.

❗ Current head 9e9dd6d differs from pull request most recent head c87a714. Consider uploading reports for the commit c87a714 to get more accurate results

@@            Coverage Diff             @@
##             next    #1313      +/-   ##
==========================================
+ Coverage   32.98%   33.05%   +0.07%     
==========================================
  Files          42       42              
  Lines       11934    12018      +84     
==========================================
+ Hits         3936     3973      +37     
- Misses       7998     8045      +47     

Impacted Files	Coverage Δ
source/view.c	0.00% <0.00%> (ø)
source/xcb.c	0.00% <0.00%> (ø)
source/theme.c	35.49% <57.14%> (+0.37%)	⬆️
lexer/theme-lexer.l	74.68% <100.00%> (+0.25%)	⬆️
lexer/theme-parser.y	63.97% <100.00%> (+0.56%)	⬆️
source/widgets/widget.c	49.84% <100.00%> (+0.15%)	⬆️
test/theme-parser-test.c	98.31% <100.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c006a...c87a714. Read the comment docs.

[DaveDavenport]

Nice.
For me the textbox does not work and the side-bar buttons are not changed.
I wonder if we should make it a property on the widget itself.

[TonCherAmi]

For me the textbox does not work and the side-bar buttons are not changed.

Huh, interesting.. Could you please share your config?

I wonder if we should make it a property on the widget itself.

Yeah, I guess that would be ideal and I would personally prefer it that way, although I feel like that would take more effort to implement and I'm not sure how useful it would end up being really.

[TonCherAmi]

Actually, it doesn't look that difficult to do, I'm going to give it a shot.

[DaveDavenport]

I ran it with -no-config.
rofi -no-config -show run -sidebar-mode

[TonCherAmi]

Yep, the sidebar buttons do not work. However the input box seems fine on my system. I think the issue might be that the cursor name for the I-beam on yours is not in the names array. I'll try searching for some more alternative names, they seem to vary from theme to theme so it's a bit difficult to get them right.

[DaveDavenport]

I never set cursor themes anymore..

(long long long ago I did write a small ui to select them, gcursor, but that got absorbed into gnome settings at some point (and removed again)).

[TonCherAmi]

I never set cursor themes anymore..

I think it's not cursor themes specifically, but rather GTK themes in general.

I've mostly got widget properties working, though there's a small problem with the recently added -hover-select option since it relies on the fact that listview_element_motion_notify is called conditionally and we now must call it unconditionally so that the cursor is updated for every widget. How do you feel about removing that option and making selection on hover the default behavior?

[DaveDavenport]

no direct feeling.. don't use mouse with rofi myself. Will give it some thoughts.

[TonCherAmi]

no direct feeling.. don't use mouse with rofi myself. Will give it some thoughts.

Nevermind.. We can just check the setting inside the handler, no need to remove it.

[TonCherAmi]

@DaveDavenport I've implemented the new property and it seems to work okay, please let me know if there's anything I've missed. The textbox issue should also probably be fixed now.

[DaveDavenport]

Looks good.

Seems to fully work for me.

[DaveDavenport]

thanks.`

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.