Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #1

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Dev #1

merged 6 commits into from
Jul 18, 2022

Conversation

ggomma
Copy link
Contributor

@ggomma ggomma commented Jul 16, 2022

Implementation of soulbound token for KBW.

@ggomma ggomma added the enhancement New feature or request label Jul 16, 2022
@ggomma ggomma requested a review from wotomas July 16, 2022 09:39
@ggomma ggomma self-assigned this Jul 16, 2022
@wotomas
Copy link

wotomas commented Jul 17, 2022

리뷰 완료. Operable 의 경우 혹시 어디 참고하신 네이밍인건가용?
그나마 가장 유력한 EIP가 몇개 있는데, 이거 스레드 팔로업 하면서 스레드에도 인풋 넣을 수 있으면 EIP에 기여 할 수 있는 좋은 전략일듯.

EIP-4973: Account-bound Tokens

EIP-5114: Soulbound Token

EIP-5192: Minimal Soulbound NFTs

지금 단계에서 쓸 수 있는 좋은 평가 기준은 인터페이스의 자유도 + 주도 하는 애들의 reputation 정도 리서치 해볼 수 있을듯.

@ggomma
Copy link
Contributor Author

ggomma commented Jul 18, 2022

  1. "Operable"은 Openzeppelin AccessControl 컨트랙트의 경량화 버전으로 제가 직접 추가하여서 따로 참고한 것은 없습니다.
  2. EIP4973 반영 검토하겠습니다.

@ggomma ggomma closed this Jul 18, 2022
@ggomma ggomma reopened this Jul 18, 2022
@ggomma ggomma merged commit e86321d into main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants