-
Notifications
You must be signed in to change notification settings - Fork 360
Add Logger and support log level #437
Comments
Hi @noaabarki , I can work on this issue. 🚀👨🚀 |
Hi @imrushi, thanks for your time! At the moment we would want a lean version so you can implement the error logs only. The implementation should be in a new folder inside Let me know if it's clear now :) |
Hi @imrushi! I hope you are well. Just wanted to ping you regarding this issue to check if everything is clear. Do you need any help or guidance? Please, don't hesitate to reach out. 💪🏻😎 |
Hi, @noaabarki I am a little bit confused. in the
Let me know if this is right... and correct me if I am wrong. |
@imrushi, I'm not sure I understand. The way I see it, we should replace current printings (using |
Hey, I want to work on this issue. |
Hi @amustaque97, You can take this issue ahead. Sorry for the inconvenience. |
@amustaque97 You got it 🤗 |
Hey, sorry to interfere in such a late stage of the issue, but I think it might be better using https://github.com/uber-go/zap here since it is already implemented in the https://github.com/datreeio/admission-webhook-datree repo. Maybe even using/modifying the package there to be used in both admission webhook and CLI Plus, I didn't understand exactly what should be the use of @noaabarki @amustaque97 WDYT? |
My understanding is that this might be used in the CI logs. |
@myishay I understand that it might be easier for maintenance but still, I don't think it's necessary to have the same logger library in both projects. As @amustaque97 said, since logrus writes log entries as JSON automatically it's more suitable for CI logs. |
@noaabarki hmm I understand. |
Describe the solution you'd like
We want to add logger in order to provide more useful info and help our user more conveniently detect errors.
Requirements
Golang basic level.
“How to Implement” suggestion
logrus
package. [Read more](https://github.com/sirupsen/logrus)logrus.Error
.The text was updated successfully, but these errors were encountered: