Skip to content

Commit

Permalink
Remove pytest-flake8; unmaintained and broken
Browse files Browse the repository at this point in the history
  • Loading branch information
athornton committed Dec 20, 2023
1 parent 308e227 commit 7cade8e
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion dev-requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

pip-tools
tox
flake8
pytest
pytest-flake8
pytest-isort
pytest-mypy
pytest-env
Expand Down
5 changes: 1 addition & 4 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ filelock==3.13.1
# tox
# virtualenv
flake8==6.1.0
# via pytest-flake8
# via -r dev-requirements.in
furo==2022.9.29
# via -r dev-requirements.in
google-auth==2.25.2
Expand Down Expand Up @@ -147,16 +147,13 @@ pytest==7.4.3
# -r dev-requirements.in
# pytest-cov
# pytest-env
# pytest-flake8
# pytest-isort
# pytest-mypy
# pytest-vcr
pytest-cov==4.1.0
# via -r dev-requirements.in
pytest-env==1.1.3
# via -r dev-requirements.in
pytest-flake8==1.1.1
# via -r dev-requirements.in
pytest-isort==3.1.0
# via -r dev-requirements.in
pytest-mypy==0.10.3
Expand Down
2 changes: 1 addition & 1 deletion docs/source/developer-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ endpoint implementation with Flask
input / output serialization and validation
* [figcan](https://github.com/shoppimon/figcan) for configuration handling

You must have Python 3.7 and newer set up to run or develop `giftless`.
You must have Python 3.10 or newer set up to run or develop `giftless`.

## Code Style
We use the following tools and standards to write `giftless` code:
Expand Down
2 changes: 1 addition & 1 deletion giftless/auth/jwt.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def _generate_token(self, **kwargs) -> str:
# Type of jwt.encode() went from bytes to str in jwt 2.x, but the
# typing hints somehow aren't keeping up. This lets us do the
# right thing with jwt 2.x.
if type(token) == str:
if isinstance(token, str):
return token # type: ignore
return token.decode('ascii')

Expand Down
2 changes: 1 addition & 1 deletion pytest.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[pytest]
addopts = --flake8 --isort --mypy --doctest-modules
addopts = --isort --mypy --doctest-modules
testpaths =
tests
env =
Expand Down
3 changes: 1 addition & 2 deletions requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,4 @@ azure-storage-blob~=12.19
google-cloud-storage~=2.14
boto3~=1.34

# https://github.com/PyCQA/flake8/pull/1438
importlib-metadata<4.3; python_version < '3.11'
importlib-metadata; python_version < '3.11'
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ idna==3.6
# via
# anyio
# requests
importlib-metadata==4.2.0 ; python_version < "3.11"
importlib-metadata==7.0.0 ; python_version < "3.11"
# via -r requirements.in
isodate==0.6.1
# via azure-storage-blob
Expand Down

0 comments on commit 7cade8e

Please sign in to comment.