-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[push] Display upload progress to user #116
Milestone
Comments
4 tasks
4 tasks
anuveyatsu
added a commit
to datopian/datahub-client
that referenced
this issue
Mar 6, 2018
anuveyatsu
added a commit
to datopian/datahub-client
that referenced
this issue
Mar 6, 2018
anuveyatsu
added a commit
that referenced
this issue
Mar 6, 2018
anuveyatsu
added a commit
to datopian/datahub-client
that referenced
this issue
Mar 6, 2018
* [progress bar][s]: now we show progress bar of each file being uploaded - refs datopian/data-cli#116 * [progress bar][xs]: clear a progress bar once completed - refs datopian/data-cli#116
anuveyatsu
added a commit
to datopian/datahub-client
that referenced
this issue
Mar 8, 2018
…ed after clearing progress bar - refs datopian/data-cli#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, when pushing packages, especially big ones, it is not clear what's happening. We want to have a progress bar so users know which stage is being processed.
Acceptance criteria
Tasks
push
method ofDataHub
class indatahub-client
libraryformData
and implement it along with the progress bardata-cli
library to work with itAnalysis
We will use
progress
npm package to implement the progress bar - https://www.npmjs.com/package/progressSee example here https://github.com/visionmedia/node-progress/blob/master/examples/download.js
Using the example above, implement progress bar here - https://github.com/datahq/datahub-cli/blob/master/lib/utils/datahub.js#L49-L82
Use
totalLength
fortotal
parameter.Not sure if we can use fetch here: JakeChampion/fetch#89
The text was updated successfully, but these errors were encountered: