Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[push] Display upload progress to user #116

Closed
4 tasks done
rufuspollock opened this issue Jul 18, 2017 · 1 comment
Closed
4 tasks done

[push] Display upload progress to user #116

rufuspollock opened this issue Jul 18, 2017 · 1 comment
Assignees
Milestone

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Jul 18, 2017

At the moment, when pushing packages, especially big ones, it is not clear what's happening. We want to have a progress bar so users know which stage is being processed.

Acceptance criteria

  • When I do push, I can see the progress of upload process

Tasks

  • refactor push method of DataHub class in datahub-client library
    • add a listener for formData and implement it along with the progress bar
  • refactor data-cli library to work with it

Analysis

We will use progress npm package to implement the progress bar - https://www.npmjs.com/package/progress

See example here https://github.com/visionmedia/node-progress/blob/master/examples/download.js

Using the example above, implement progress bar here - https://github.com/datahq/datahub-cli/blob/master/lib/utils/datahub.js#L49-L82
Use totalLength for total parameter.

Not sure if we can use fetch here: JakeChampion/fetch#89

@anuveyatsu anuveyatsu added this to the Sprint - 14 Aug 2017 milestone Aug 4, 2017
@anuveyatsu anuveyatsu self-assigned this Aug 4, 2017
@rufuspollock rufuspollock self-assigned this Aug 17, 2017
@anuveyatsu anuveyatsu assigned anuveyatsu and unassigned rufuspollock Mar 6, 2018
anuveyatsu added a commit to datopian/datahub-client that referenced this issue Mar 6, 2018
anuveyatsu added a commit to datopian/datahub-client that referenced this issue Mar 6, 2018
* [progress bar][s]: now we show progress bar of each file being uploaded - refs datopian/data-cli#116

* [progress bar][xs]: clear a progress bar once completed - refs datopian/data-cli#116
@anuveyatsu
Copy link
Member

anuveyatsu commented Mar 6, 2018

FIXED - will be available in release >v0.8.2

screen shot 2018-03-30 at 16 15 20

anuveyatsu added a commit to datopian/datahub-client that referenced this issue Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants