Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proper NoneType conversions when handling nested dataclass members and such. #3

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

JackUrb
Copy link

@JackUrb JackUrb commented Jul 19, 2024

Before:

TypeError: Failed to convert inputs of task 'workflows.subgraphs.geometric_filtering.build_geometric_filtering_outputs':
  Failed argument 'density': Python value cannot be None, expected <class 'NoneType'>/[Flyte Serialized object: Type: 
<LiteralType> Value: <simple: NONE>]

This is pretty nonsensical, upset that the value is None when NoneType is expected.

The fix is pretty simple, and this no longer happens.

@JackUrb JackUrb requested a review from jw-mcgrath July 19, 2024 20:02
@JackUrb JackUrb merged commit 4a6d4dc into master Jul 19, 2024
@JackUrb JackUrb deleted the ju-nonetype-ok-convert branch July 19, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant