Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply patches for lists and optionals #1

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Apply patches for lists and optionals #1

merged 2 commits into from
Jun 21, 2024

Conversation

jw-mcgrath
Copy link

Some of the patches jack applied + some I found while getting things to run locally

JackUrb
JackUrb approved these changes Jun 21, 2024
View reviewed changes
Copy link

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - what led you to changing the assert_type call?

@jw-mcgrath
Copy link
Author

We were failing on TypeError: isinstance() argument 2 cannot be a parameterized generic because get_origin has different behavior if you use A|B vs typing.Union[A,B] which is super annoying.

@jw-mcgrath jw-mcgrath merged commit 215dfad into master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackUrb JackUrb JackUrb approved these changes

@hurrycane hurrycane Awaiting requested review from hurrycane

@fp2302 fp2302 Awaiting requested review from fp2302

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jw-mcgrath @JackUrb