-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related discussions #10
Conversation
What do you think? |
@@ -55,6 +57,9 @@ export default class MoreDiscussions<CustomAttrs> extends Component { | |||
limit: this.limit, | |||
}, | |||
sort: this.filterBy, | |||
filter: { | |||
q: this.isRelated ? app.current.data.discussion.title : null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like it is app.current.data.discussion.title()
not app.current.data.discussion.title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this also be resolved #7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Should we add a disclaimer that if the option is activated on big sites without https://github.com/clarkwinkelmann/flarum-ext-scout it's going to affect a lot to site performance? |
Yeah, I think so. Can you add a notice to the help text of the Related results field. |
No description provided.