Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

describegpt: add --jsonl option (resolves #1086) #1127

Merged
merged 4 commits into from
Jul 12, 2023
Merged

describegpt: add --jsonl option (resolves #1086) #1127

merged 4 commits into from
Jul 12, 2023

Conversation

rzmk
Copy link
Collaborator

@rzmk rzmk commented Jul 12, 2023 •
edited
Loading

@rzmk rzmk self-assigned this Jul 12, 2023
@rzmk rzmk requested a review from jqnatividad July 12, 2023 15:57
jqnatividad
jqnatividad approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@jqnatividad jqnatividad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @rzmk . LGTM!
Merging and will collaborate on master as usual.

@jqnatividad jqnatividad merged commit 73db2ba into master Jul 12, 2023
@jqnatividad jqnatividad deleted the describegpt/jsonl branch July 13, 2023 05:43
@moonfruit moonfruit mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jqnatividad jqnatividad jqnatividad approved these changes

Assignees

@rzmk rzmk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

describegpt: add a --jsonl option to save results to a jsonl, if the file exists, add the result to it
2 participants
@rzmk @jqnatividad