-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
higher image quality, tweak webp hint #692
Conversation
mal-tee
commented
Sep 23, 2021
•
edited
Loading
edited
- the tweaked hint gets rid of the weird lines in, e.g. this image
- UPDATE: seems like that didn't do the trick
- the higher quality (default is 75) gets rid of some compression artifacts, but comes with a slight size increase
- 15% or 0.77 KB for my test thumbnail in my local build
- 22% or 5.94KB for the same image in big
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
"Fix transparency problem when converting 32-bit images to WebP 8f40f34c @bep #8729" |
I'm definitely on board with changing the hint and updating Hugo. The size increase for the thumbnails is also ok with me. As for the regular images, that is a more significant increase (especially in absolute terms, which matters more imo). I just did a little non-scientific blind test trying to guess which of the versions is the "better" one and while I can see small differences, I was genuinely wrong more than half of the time… I'll let @zner0L decide whether we want to crank up the quality. |
I agree, its not that important for most images. Maybe in the future I will just add an option for higher quality to some thumbnails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!