Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

higher image quality, tweak webp hint #692

Merged
merged 3 commits into from
Sep 26, 2021
Merged

higher image quality, tweak webp hint #692

merged 3 commits into from
Sep 26, 2021

Conversation

mal-tee
Copy link
Member

@mal-tee mal-tee commented Sep 23, 2021

  • the tweaked hint gets rid of the weird lines in, e.g. this image
    • UPDATE: seems like that didn't do the trick
  • the higher quality (default is 75) gets rid of some compression artifacts, but comes with a slight size increase

@cypress
Copy link

cypress bot commented Sep 23, 2021



Test summary

57 0 7 0


Run details

Project datenanfragen/website
Status Passed
Commit fda1b5d
Started Sep 24, 2021 9:53 PM
Ended Sep 24, 2021 9:55 PM
Duration 02:19 💡
OS Linux Debian - 10.3
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mal-tee
Copy link
Member Author

mal-tee commented Sep 24, 2021

"Fix transparency problem when converting 32-bit images to WebP 8f40f34c @bep #8729"

@baltpeter
Copy link
Member

baltpeter commented Sep 24, 2021

I'm definitely on board with changing the hint and updating Hugo. The size increase for the thumbnails is also ok with me.

As for the regular images, that is a more significant increase (especially in absolute terms, which matters more imo). I just did a little non-scientific blind test trying to guess which of the versions is the "better" one and while I can see small differences, I was genuinely wrong more than half of the time…

I'll let @zner0L decide whether we want to crank up the quality.

@baltpeter baltpeter requested a review from zner0L September 24, 2021 15:02
@mal-tee
Copy link
Member Author

mal-tee commented Sep 24, 2021

I agree, its not that important for most images. Maybe in the future I will just add an option for higher quality to some thumbnails.

@mal-tee mal-tee requested review from baltpeter and removed request for zner0L September 24, 2021 21:48
Copy link
Member

@baltpeter baltpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baltpeter baltpeter merged commit 527f657 into master Sep 26, 2021
@baltpeter baltpeter deleted the m_image_config branch September 26, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants