Suggest: Hide required elements and comments #1103
Conversation
We never know whether people are just guessing for the required elements and usually end up removing them anyway for that reason. And as for the comments: Records should only have comments in very rare cases. This field just encouraged people to leave the kinds of comments that should be left on the company pages instead.
Passing run #4985 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
There was a problem hiding this comment.
And as for the comments: Records should only have comments in very rare cases. This field just encouraged people to leave the kinds of comments that should be left on the company pages instead.
I don't think I agree with this. Sometimes people leave comments with further information, which could fit into our scheme, but we can not expect that everybody adheres to our rules when they want to add a company (for the first time). I think its important to have some "freestyle" comment field for suggest. It doesn't have to be the schema.json comment ofc.
|
Exactly, I'm fine with having a free-form comment field that just posts comments in the GitHub PR. But having those go to the record comments is just wrong (and people regularly misread the current comment field as such). |
|
Would you mind opening an issue for that then, so that we can implement this later? |
|
If we postpone the new comment feature, we will never implement it. A PR that disables the status quo comments should introduce a new comment feature as well imo. |
|
Do i get it right, the following change is requested:
right? |
We never know whether people are just guessing for the required elements and usually end up removing them anyway for that reason.
And as for the comments: Records should only have comments in very rare cases. This field just encouraged people to leave the kinds of comments that should be left on the company pages instead.