-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the broken anchor links in the headings #1020
base: master
Are you sure you want to change the base?
Conversation
2 failed tests on run #4528 ↗︎
Details:
cypress/integration/use-cases/reactor.spec.js • 2 failed tests
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
In Firefox 110 I can only click them if I approach them from the text, i.e. hovering from right to left. They won't appear if you come from the left which is kinda odd. |
Either I don't understand what you mean, or I do not have this problem. I haven't updated Firefox to 110, yet, but I doubt that would change anything. |
I also get this in Chromium 110/Linux and Firefox 110/Linux. |
Same, plus a few other issues. I started working on a fix a few weeks ago but got pretty annoyed (mostly about the alignment) and haven't continued since. :D |
Ah, that is what you mean! I don't expect that behavior at all… |
Am I supposed to do anything here? I don’t really think what you describe is expected behavior and it is certainly annoying to implement. |
I am convinced that it is. Consider two cases:
And honestly, even as someone who does know how the hover state works and why it behaves the way it does, I find it quite annoying to get to the anchor thingy. And you better be careful not to move the mouse too much after you have activated the hover state. Otherwise you have to start again at the heading. Kind of like one of these annoying flash games from back in the day. :P 1020-before.mp4Now look at my alternative implementation. The alignment is off (though it really isn't perfect for yours either), but it clearly feels so much more natural: 1020-after.mp4I do also remember having some accessibility concerns about the markup, but unfortunately I didn't write those down as I had assumed that I would just fix them myself… |
The anchor links I introduced looked hideous and didn't really work well, so this is my second attempt.