Release 16.2.1 #808
Merged
Release 16.2.1 #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional `diffSubtypes` to `IMultiSelectionAdapter` - Remove `ReprovisynMultiSelectionAdapter` - Add generics to `MultiSelectionAdapter` - Comment functions of `MultiSelectionAdapter`
Unecessary convoluted call
- Add and refactor return types `Promise<any>` to `Promise<void>` - Switch to async/await where possible - await `removeDynamicColumns` before `addDynamicColumns` -> previously it was not waited for the removal
* Added build-storybook to build script * Add tdp_core/dist alias to the storybook webpack config * updated version of storybook (#736) Co-authored-by: Moritz Heckmann <[email protected]> Co-authored-by: dvmoritzschoefl <[email protected]> Co-authored-by: Moritz Heckmann <[email protected]>
Probably a missing type cast in PR #729
Waiting for `this.built` will never resolve/terminate and show an infite loading icon. Reason: `this.built` is created with `build()` in line 355 and it is only resolved after the `build()` call is complete. With the changes to the selection adapter the `this.selectionAdapter.selectionChanged` now returns a valid promise. Previously, `context.add()` did not return it's promise (see 919cfb2#diff-f0f07e4a6ac30a813315b152545245d4cf26830e01b701f3e82ff7b5c22363a7R18). Now, we are waiting until all dynamic columns are added. The circle closes when we add the columns which calls `withoutTracking()` which in-turn is waiting for the resolved `this.built` promise. As far as I can see, we always call `withoutTracking` on a built/resolved ranking view. In the other places (line 377 and 400) we have a dedicated `await this.built;` before triggering changes to dynamic columns. In my tests adding and removing columns via score and selection adapter worked as before. I also tested reloading the page and checked the result of the session. In all cases it looks the same as before.
Co-authored-by: Holger Stitz <[email protected]>
Co-authored-by: Holger Stitz <[email protected]>
* Improve typings for CLUE `graph.persist()` datavisyn/ordino_eins#525 * Fix typing of MemoryGraph.restore()
Previously the general vis was intialized and running the background, even though it was disabled; only the button was hidden. Now the general vis not even initialized.
Co-authored-by: Holger Stitz <[email protected]>
chore: Update dependency [email protected] Co-authored-by: Michael Pühringer <[email protected]>
Co-authored-by: Holger Stitz <[email protected]>
…abled (#801) Co-authored-by: Holger Stitz <[email protected]>
dvvanessastoiber
added
the
release: patch
thinkh
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
AttachmentUtilscalls when Reprovisyn feature flag is enabled #801)violingap#807)Release dependencies first
In case of dependent Phovea/TDP repositories follow dependency tree from the top:
🏁 Finish line