-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding hexbin to vis #790
Adding hexbin to vis #790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome new visualization. It looks already very good. Please see my comments below.
- The mouse while should work in
If no numerical columns are selected the message currently takes the full height of the vies view (should be only the height of the text).
- Hexbin plot (sentence case)
- Invalid settings (sentence case)
- Convert invalid settings card to Mantine info alert (currently bootstrap)
- Also for all other cards and visualizations
- Horizontally center the info alert
- Hexbin options (sentence case)
- Add tooltips to brush option buttons
- Enable zoom with mouse wheel in brush mode (currently, it only works in pan mode)
- Make list of categories in legend scrollable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvzacharycutler Thanks for your bug fixes. It works now much better. I still found a few inconsistencies that should be removed before merging this PR.
Steps to reproduce
- Select hexbin plot
- Remove all columns
Observed behavior
The message shows Scatterplot
.
Expected behavior
- The message should mention the Hexbin plot when this plot is selected
- Consistent spelling: Scatter plot vs. Scatterplot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvzacharycutler I tested this branch with Ordino public in a local workspace and found a couple of problems. The problems might be related to #786 and not specifically to this PR. You can decide where to fix it.
Here an overview of the interaction with the general visualization of this branch:
ordino-hexbin.webm
Scatter plot: Opacity does not have an effect
Sometimes the opacity slider does not have any effect.
As you can see in the video above, it worked somehow after playing around and switching visualization. But it does not work when I opened it the first time (see screenshots).
Scatter plot: Legend overlaying visualization
The legend is overlaying the visualization and makes it impossible to use. Could be a flex problem in Ordino?
Hexbin plot: Wrong options panel position
When switching to hexbin plot the options panel is positioned absolute to the window and not the visualization container. (This does not happen for the other visualizations.) After closing and opening the panel again it is positioned correctly.
Furthermore the hexbin plot is empty which should be the case because the scatter plot shows data.
Various plots: scroll position and options panel
For all plot types the visualization is positioned far to the right which requires to scroll to the right. Then the options panel is positioned somewhere in the center.
Co-authored-by: Holger Stitz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the last fixes. Looks good to me.
Closes https://github.com/datavisyn/reprovisyn/issues/253
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor
) to this PR following semverCloses #...
)Summary of changes
Screenshots
newHexin.webm
Additional notes for the reviewer(s)
Thanks for creating this pull request 🤗