Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typings and upgrade tooling #28

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

jantimon
Copy link
Contributor

@jantimon jantimon commented May 2, 2023

I haven't changed the code of the source files, but I have added typings to make the package easier to use.

In addition to the typings, I've made a few other changes that I believe could benefit the project. Specifically, I've switched out Webpack for tsup and Parcel for Vite to reduce dependencies and optimize the generated assets.

Additionally, I've upgraded the project's eslint to the latest version, which has helped to resolve a number of vulnerabilities 52 vulnerabilities (2 low, 21 moderate, 23 high, 6 critical).

I hope removing the flow part from the eslint config is okay (I didn't find any flow typings in the source files).

I bumped to 4.0.0 as I added a typings and module entry to package.json.

Please let me know what you think :)

@pstadler
Copy link
Contributor

pstadler commented Jul 4, 2023

This is incredible. Thanks a lot for the effort! 🍻

@pstadler pstadler merged commit 4276af1 into datatrans:master Jul 4, 2023
@jantimon
Copy link
Contributor Author

@pstadler thanks for taking the time to review this quote huge pr 👍

looks like dropping webpack worked well:

https://bundlephobia.com/package/[email protected]

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants