[Subtask] Add Pylint Rules for client-python #3203
Comments
This was referenced Apr 29, 2024
noidname01
changed the title
xunliu
pushed a commit
that referenced
this issue
May 1, 2024
) ### What changes were proposed in this pull request? * Add pylint rule for logging, logging should use old format (%), not fstring * Unify all the logging format * Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR) ### Why are the changes needed? Fix: #3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ```bash ./gradlew :clients:client-python:test ``` --------- Co-authored-by: TimWang <[email protected]>
noidname01
added a commit
to noidname01/gravitino
that referenced
this issue
May 6, 2024
…nt (apache#3204) ### What changes were proposed in this pull request? * Add pylint rule for logging, logging should use old format (%), not fstring * Unify all the logging format * Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR) ### Why are the changes needed? Fix: apache#3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ```bash ./gradlew :clients:client-python:test ``` --------- Co-authored-by: TimWang <[email protected]>
jerryshao
pushed a commit
that referenced
this issue
May 6, 2024
) ### What changes were proposed in this pull request? * Add pylint rule for logging, logging should use old format (%), not fstring * Unify all the logging format * Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR) ### Why are the changes needed? Fix: #3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ```bash ./gradlew :clients:client-python:test ``` Co-authored-by: TimWang <[email protected]>
xunliu
pushed a commit
that referenced
this issue
May 10, 2024
### What changes were proposed in this pull request?
* Add Black as code formatter, it enforce the coding style with
1. trailing commas and whitespaces
2. unified quotation marks(")
3. new lines
4. max line length
5. indents
* Aligned with Pylint Rules
* Add Black into Gradle and form a code formatting pipeline (pipInstall
-> Black -> Pylint), this pipeline will run implicitly in `build` and
`test` gradle tasks.
> Note that Black still can't format long entire string exceeding `max
line length` without enabling unstable features, please handle long
strings with caution and make Pylint to ignore them if they are really
necessary.
### Why are the changes needed?
Fix: #3206, #3203
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
---------
Co-authored-by: TimWang <[email protected]>
noidname01
added a commit
to noidname01/gravitino
that referenced
this issue
May 10, 2024
…pache#3254) ### What changes were proposed in this pull request? * Add Black as code formatter, it enforce the coding style with 1. trailing commas and whitespaces 2. unified quotation marks(") 3. new lines 4. max line length 5. indents * Aligned with Pylint Rules * Add Black into Gradle and form a code formatting pipeline (pipInstall -> Black -> Pylint), this pipeline will run implicitly in `build` and `test` gradle tasks. > Note that Black still can't format long entire string exceeding `max line length` without enabling unstable features, please handle long strings with caution and make Pylint to ignore them if they are really necessary. ### Why are the changes needed? Fix: apache#3206, apache#3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No --------- Co-authored-by: TimWang <[email protected]>
jerryshao
pushed a commit
that referenced
this issue
May 10, 2024
#3325) ### What changes were proposed in this pull request? * Add Black as code formatter, it enforce the coding style with 1. trailing commas and whitespaces 2. unified quotation marks(") 3. new lines 4. max line length 5. indents * Aligned with Pylint Rules * Add Black into Gradle and form a code formatting pipeline (pipInstall -> Black -> Pylint), this pipeline will run implicitly in `build` and `test` gradle tasks. > Note that Black still can't format long entire string exceeding `max line length` without enabling unstable features, please handle long strings with caution and make Pylint to ignore them if they are really necessary. ### Why are the changes needed? Fix: #3206, #3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Co-authored-by: TimWang <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this issue
Jun 13, 2024
…nt (apache#3204) ### What changes were proposed in this pull request? * Add pylint rule for logging, logging should use old format (%), not fstring * Unify all the logging format * Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR) ### Why are the changes needed? Fix: apache#3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ```bash ./gradlew :clients:client-python:test ``` --------- Co-authored-by: TimWang <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this issue
Jun 13, 2024
…pache#3254) ### What changes were proposed in this pull request? * Add Black as code formatter, it enforce the coding style with 1. trailing commas and whitespaces 2. unified quotation marks(") 3. new lines 4. max line length 5. indents * Aligned with Pylint Rules * Add Black into Gradle and form a code formatting pipeline (pipInstall -> Black -> Pylint), this pipeline will run implicitly in `build` and `test` gradle tasks. > Note that Black still can't format long entire string exceeding `max line length` without enabling unstable features, please handle long strings with caution and make Pylint to ignore them if they are really necessary. ### Why are the changes needed? Fix: apache#3206, apache#3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No --------- Co-authored-by: TimWang <[email protected]>
coolderli
pushed a commit
that referenced
this issue
Dec 17, 2024
) ### What changes were proposed in this pull request? * Add pylint rule for logging, logging should use old format (%), not fstring * Unify all the logging format * Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR) ### Why are the changes needed? Fix: #3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ```bash ./gradlew :clients:client-python:test ``` --------- Co-authored-by: TimWang <[email protected]> (cherry picked from commit 1679ae0)
coolderli
pushed a commit
that referenced
this issue
Dec 17, 2024
### What changes were proposed in this pull request?
* Add Black as code formatter, it enforce the coding style with
1. trailing commas and whitespaces
2. unified quotation marks(")
3. new lines
4. max line length
5. indents
* Aligned with Pylint Rules
* Add Black into Gradle and form a code formatting pipeline (pipInstall
-> Black -> Pylint), this pipeline will run implicitly in `build` and
`test` gradle tasks.
> Note that Black still can't format long entire string exceeding `max
line length` without enabling unstable features, please handle long
strings with caution and make Pylint to ignore them if they are really
necessary.
### Why are the changes needed?
Fix: #3206, #3203
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
---------
Co-authored-by: TimWang <[email protected]>
(cherry picked from commit a88a361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the subtask
There is no linter for client-python, add pylint rules
[#3203] improvement(PyClient): Add pylint Rules for Python client #3204
[Subtask] Add Pylint Rules for client-python naming rules #3205
Parent issue
#2590
The text was updated successfully, but these errors were encountered: