issue-227: improve error handling for access list resource #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in the astra go client, if the server responds with a 403 due to limited permissions, a JSON parsing error is reported to the user instead of reporting the actual permissions issue. This works around that by moving the response parsing code into the terraform provider. This also adds a couple of nil pointer checks to prevent plugin crashes in certain situations.
zzzming
approved these changes
Sep 5, 2023
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
Due to a bug in the astra go client, if the server responds with a 403 due to limited permissions, a JSON parsing error is reported to the user instead of reporting the actual permissions issue. This works around that by moving the response parsing code into the terraform provider.
This also adds a couple of nil pointer checks to prevent plugin crashes in certain situations.