-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-1341 Impl of client-side column-level encryption/decryption #1150
Conversation
…void customized serialization and re-use the default codecs in all cases.
…cassandra.cqltypes maintains a mapping which does everything we need.
…n the non-Cython case
…... but it is now. Cython still to come.
…led to fix the issues observed when trying to upgrade PyPy.
raise ValueError("Type %s is not a supported type".format(type)) | ||
if not len(key) == AES256_KEY_SIZE_BYTES: | ||
raise ValueError("AES256 column encryption policy expects a 256-bit encryption key") | ||
self.coldata[coldesc] = ColData(key, _cqltypes[type]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a check for coldesc being None/empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! For some reason that was missed here (and in a few of the other methods). I'll add that in and incorporate it into the existing unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small questions.
Changes look good to me from a "code does what it says" perspective.
CI looks good for pure python. I would run the cython version too.
Nice job!
…rking on CLE. After we're done here we'll go back to Cython-only for smoke builds; see PYTHON-1343 for more on that.
…master version 3.27.0 * tag '3.27.0' of https://github.com/datastax/python-driver: Missed dependency on cryptography in setup.py Update docs.yaml to point to latest 3.27.0 docs, take two remove future plans (datastax#1155) Update docs.yaml to point to latest 3.27.0 docs update RH nav order (datastax#1154) Include docs for 3.27.0 (datastax#1153) Release 3.27: changelog & version PYTHON-1341 Impl of client-side column-level encryption/decryption (datastax#1150) Update ref to include latest version supported (datastax#1149) Update driver version supported (datastax#1148) Add 3.26 for docs (datastax#1147) Fix typo Doc changes following on from 3.26.0 release
No description provided.