Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-1341 Impl of client-side column-level encryption/decryption #1150

Merged
merged 27 commits into from
May 1, 2023

Conversation

absurdfarce
Copy link
Collaborator

No description provided.

…void customized serialization and

re-use the default codecs in all cases.
…cassandra.cqltypes maintains

a mapping which does everything we need.
…led to fix the issues observed

when trying to upgrade PyPy.
raise ValueError("Type %s is not a supported type".format(type))
if not len(key) == AES256_KEY_SIZE_BYTES:
raise ValueError("AES256 column encryption policy expects a 256-bit encryption key")
self.coldata[coldesc] = ColData(key, _cqltypes[type])
Copy link
Member

@JeremiahDJordan JeremiahDJordan Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a check for coldesc being None/empty?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! For some reason that was missed here (and in a few of the other methods). I'll add that in and incorporate it into the existing unit test.

Copy link
Member

@JeremiahDJordan JeremiahDJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small questions.
Changes look good to me from a "code does what it says" perspective.
CI looks good for pure python. I would run the cython version too.
Nice job!

@absurdfarce absurdfarce merged commit 058be1e into master May 1, 2023
@absurdfarce absurdfarce deleted the cle branch May 2, 2023 06:33
fruch added a commit to fruch/python-driver that referenced this pull request Jun 6, 2024
…master

version 3.27.0

* tag '3.27.0' of https://github.com/datastax/python-driver:
  Missed dependency on cryptography in setup.py
  Update docs.yaml to point to latest 3.27.0 docs, take two
  remove future plans (datastax#1155)
  Update docs.yaml to point to latest 3.27.0 docs
  update RH nav order (datastax#1154)
  Include docs for 3.27.0 (datastax#1153)
  Release 3.27: changelog & version
  PYTHON-1341 Impl of client-side column-level encryption/decryption (datastax#1150)
  Update ref to include latest version supported (datastax#1149)
  Update driver version supported (datastax#1148)
  Add 3.26 for docs (datastax#1147)
  Fix typo
  Doc changes following on from 3.26.0 release
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Aug 9, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Aug 9, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Aug 9, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Aug 9, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Aug 15, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Nov 10, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Nov 18, 2024
dkropachev pushed a commit to dkropachev/python-driver that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants