upgrade quarkus-sdk 5.0.1->5.1.4 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgier
force-pushed
the
upgrade-operator-sdk
branch
2 times, most recently
from
b2ecbe6 to
97bdda2
Compare
pgier
force-pushed
the
upgrade-operator-sdk
branch
from
97bdda2 to
ec2acfd
Compare
nicoloboschi
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this before seeing #102, however, it should be fine to merge this one before that one get merged. That's a bit bigger upgrade so it involves more significant changes.
There was a change to the
execoperation in the upstream kubernetes-client (fabric8io/kubernetes-client#4505) where it first callsgeton the pod to get the container names, so this changes the mock server to expect this extra call.