Increment records/failed counter for failed writes #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
commented
Aug 10, 2022
...w/commons/src/main/java/com/datastax/oss/dsbulk/workflow/commons/metrics/MetricsManager.java
Show resolved
Hide resolved
adutra
commented
Aug 10, 2022
| @@ -234,6 +237,7 @@ public boolean execute() { | |||
| statements | |||
| .transform(this::executeStatements) | |||
| .transform(queryWarningsHandler) | |||
| .transform(failedWritesMonitor) | |||
There was a problem hiding this comment.
This was the root cause of the bug: the monitor that increments the records/failed metric wasn't being invoked here, and so failed writes weren't being accounted for.
adutra
commented
Aug 10, 2022
| @@ -733,7 +738,7 @@ public Publisher<Publisher<Record>> read( | |||
| assertStatus(status, STATUS_COMPLETED_WITH_ERRORS); | |||
| assertThat(logs.getAllMessagesAsString()) | |||
| .contains("completed with 11000 errors") | |||
| .contains("Records: total: 100,000, successful: 90,000, failed: 10,000") | |||
| .contains("Records: total: 100,000, successful: 89,000, failed: 11,000") | |||
There was a problem hiding this comment.
This bug report unveiled a flaw in this existing assertion.
|
I've now tested the new binary built from this branch, and can see console reporter correctly showing the number of failed operations. LGTM |
weideng1
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444.