PR 522 followup #526
Merged
PR 522 followup #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absurdfarce
commented
Mar 28, 2022
| cert = PEM_read_bio_X509(bio, NULL, pem_password_callback, NULL)) | ||
| { | ||
| for (X509* cert = PEM_read_bio_X509(bio, NULL, pem_password_callback, NULL); cert != NULL; | ||
| cert = PEM_read_bio_X509(bio, NULL, pem_password_callback, NULL)) { |
There was a problem hiding this comment.
Formatting change which was leading to Jenkins build failures on PR 522. The format check was only failing on Ubuntu Bionic instances so it's worth validating that we're okay on the other platforms as well... last thing we need is to introduce a failure somewhere else via this change.
absurdfarce
commented
Mar 28, 2022
| Cluster cluster = default_cluster().with_ssl(ssl); | ||
| connect(cluster); | ||
| write_and_read(); | ||
| } |
There was a problem hiding this comment.
Simple integration test for the functionality added in PR 522.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR 522. Fix the formatting issue that was breaking the Jenkins build for Ubuntu Bionic and add an integration test to validate the change.