-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support universal base image #95
Merged
Merged
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
64006e4
baby steps
sandoichi 153c8f3
build out some more steps
sandoichi 34922cb
write file with base os
sandoichi d562174
add logic to select ubi image in mage targets
sandoichi c7a9757
use ubi instead of busybox when necessary for logging container; buil…
sandoichi 6db60cf
unify gh workflows and simplify steps
sandoichi a7da497
fixup! unify gh workflows and simplify steps
sandoichi 8aac13d
fixup! fixup! unify gh workflows and simplify steps
sandoichi bb6dc8a
add debug print
sandoichi c7f6fd4
fixup workflow tags to push
sandoichi 55e0cff
trimspace on gh package tags
sandoichi 6236cd7
fixup! trimspace on gh package tags
sandoichi c4e6295
more trimspace
sandoichi b75fb46
add in logic for choosing ubi based config builder image
sandoichi 97e30c2
add in dse and config builder ubi coords
sandoichi 89540fd
add oss c* 3.11.6 image
sandoichi 14d4c91
prefix ioutil import
sandoichi 288402c
Add debug cat cmd to gh action
sandoichi 7c7cfb8
Merge remote-tracking branch 'origin/master' into support-universal-b…
sandoichi ce01958
add conditions around checkout rules in gh workflow to avoid merging
sandoichi 0710032
Remove debug print in gh workflow
sandoichi 472a65e
Merge remote-tracking branch 'origin/master' into support-universal-b…
sandoichi 3c6c780
use separate dockerfile for ubi images
sandoichi cb76c87
only run docker build once now
sandoichi 7808c31
debug print in workflow
sandoichi ab4f8b6
more debug
sandoichi 0aaf87b
fixup! more debug
sandoichi 0b385eb
fixup! fixup! more debug
sandoichi 96080eb
fixup! fixup! fixup! more debug
sandoichi c1ff59c
use env constant instead of string; more gh workflow debugging
sandoichi 44fb640
workflow should be in good shape now
sandoichi 200bff9
use correct docker tags file for gh package pushing..
sandoichi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to use the
EnvBaseImageOs
constant here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, good catch!