Add diagrams #90
Merged
Add diagrams #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johntrimble
requested review from
bradfordcp,
jimdickinson,
respringer and
sandoichi
as code owners
johntrimble
commented
May 14, 2020
| operatorSdkImage = "operator-sdk-binary" | ||
| testSdkImage = "operator-sdk-binary-tester" | ||
| genClientImage = "operator-gen-client" | ||
| mermaidJsImage = "operator-mermaid-js" |
There was a problem hiding this comment.
Prefixing with "operator-" to prevent collision with any actual mermaid-js image a user might have. As far as I know, there is not currently an official one.
johntrimble
commented
May 14, 2020
| @@ -0,0 +1,15 @@ | |||
| # based on https://github.com/mermaid-js/mermaid.cli/blob/33a8334293308af13d307d5c3754841636e46da8/Dockerfile | |||
There was a problem hiding this comment.
While the official repo does have a Dockerfile, there is, currently, no docker image on dockerhub, and also the Dockerfile doesn't work.
johntrimble
commented
May 14, 2020
|
|
||
| RUN apt-get update && \ | ||
| apt-get install -y gconf-service libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxss1 libxtst6 libappindicator1 libnss3 libasound2 libatk1.0-0 libc6 ca-certificates fonts-liberation lsb-release xdg-utils wget &&\ | ||
| npm install @mermaid-js/[email protected] |
There was a problem hiding this comment.
There is a known issue with installing mermaid-js globally: https://github.com/mermaid-js/mermaid.cli#install-globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds diagrams for what the operator does when scaling up and updating a CassandraDatacenter. It also adds a mage task to generate these diagrams using mermaid-js.