KO-382 cleanup after scaleup #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandoichi
requested review from
bradfordcp,
jimdickinson,
johntrimble and
respringer
as code owners
jimdickinson
reviewed
May 8, 2020
| body: body, | ||
| } | ||
|
|
||
| _, err = callNodeMgmtEndpoint(client, request, "application/json") |
There was a problem hiding this comment.
there is an http constant for this, I think
jimdickinson
reviewed
May 8, 2020
Comment on lines
+175
to
+186
| postData := make(map[string]interface{}) | ||
| if jobs > -1 { | ||
| postData["jobs"] = strconv.Itoa(jobs) | ||
| } | ||
|
|
||
| if keyspaceName != "" { | ||
| postData["keyspace_name"] = keyspaceName | ||
| } | ||
|
|
||
| if len(tables) > 0 { | ||
| postData["tables"] = tables | ||
| } |
There was a problem hiding this comment.
Do you think this is nicer? It's not exactly the same logic, yet
postData := struct {
Jobs string `json:"jobs"`
Keyspace string `json:"keyspace_name"`
Tables []string `json:"tables"`
}{
Jobs: strconv.Itoa(jobs),
Keyspace: keyspaceName,
Tables: tables,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.