Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added label to all-pods service to narrow metrics scrape selection #277

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Added label to all-pods service to narrow metrics scrape selection #277

merged 1 commit into from
Oct 20, 2020

Conversation

itzg
Copy link
Contributor

@itzg itzg commented Oct 8, 2020

This change adds a label cassandra.datastax.com/prom-metrics: true to the {cluster}-{dc}-all-pods-service in order to narrow the service selector in the Prometheus operator's ServiceMonitorSpec. Prior to this change both of the services in the following listing would get selected and scraped:

NAME                            TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)                      AGE   LABELS
cluster1-dc1-all-pods-service   ClusterIP   None           <none>        9042/TCP,8080/TCP,9103/TCP   90m   app.kubernetes.io/managed-by=cass-operator,cassandra.datastax.com/cluster=cluster1,cassandra.datastax.com/datacenter=newflood-dc1
cluster1-dc1-service            ClusterIP   None           <none>        9042/TCP,8080/TCP,9103/TCP   90m   app.kubernetes.io/managed-by=cass-operator,cassandra.datastax.com/cluster=cluster1,cassandra.datastax.com/datacenter=newflood-dc1

cc @jimdickinson

Fixes #276

@itzg
Copy link
Contributor Author

itzg commented Oct 8, 2020

One of the check failures seems to be beyond my control

https://github.com/datastax/cass-operator/runs/1228413780?check_suite_focus=true#step:10:9

@jimdickinson
Copy link
Collaborator

jimdickinson commented Oct 13, 2020

@itzg thank you! could you sign the DataStax CLA at https://cla.datastax.com ?

@itzg
Copy link
Contributor Author

itzg commented Oct 13, 2020

@jimdickinson I have now signed the CLA.

@jimdickinson
Copy link
Collaborator

One of the check failures seems to be beyond my control

https://github.com/datastax/cass-operator/runs/1228413780?check_suite_focus=true#step:10:9

Sorry I dragged my feet on this one - I looked into this issue and there was nothing to do about it. We'll re run tests on master and make sure all is well. Thanks for the contribution!

@jimdickinson jimdickinson merged commit 193afa5 into datastax:master Oct 20, 2020
@jimdickinson jimdickinson linked an issue Nov 19, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants