KO-384 Refactor out webhook and improve validation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldondevat
requested review from
bradfordcp,
jimdickinson,
johntrimble and
respringer
as code owners
|
@eldondevat Is this PR just moving code to a different file? I'm totally on board with that I just want to make sure I didn't miss something. |
We should include the certificates in the standard system certificates location if available. If we have customers who want to generically deploy a specific internal set of certificates, being able to replace them in the standard location may be preferable.
eldondevat
changed the title
|
Sorry @johntrimble I don't think this PR was really very precise before, and the single commit nature of it didn't make that easier, I've added some more detail. Thanks! |
jimdickinson
reviewed
Jun 4, 2020
Co-authored-by: Jim Dickinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the webhook slightly more precise, in that we validate the namespace of the service that is used for the webhook is actually our namespace. I also added documentation on the webhook in the developer documentation folder. New additional validation happens here :
cass-operator/operator/cmd/manager/webhook.go
Line 34 in 81a86a8
cass-operator/operator/cmd/manager/webhook.go
Line 117 in 81a86a8