Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Datasette 0.14a0 #7

Closed
simonw opened this issue Aug 5, 2024 · 5 comments
Closed

Update for Datasette 0.14a0 #7

simonw opened this issue Aug 5, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Contributor

simonw commented Aug 5, 2024

Refs:
@simonw simonw added the bug Something isn't working label Aug 5, 2024
simonw added a commit that referenced this issue Aug 5, 2024
@simonw
Bump to datasette>=1.0a14
4ce22f9 
This breaks the tests, as expected

Refs #7
@simonw
Copy link
Contributor Author

simonw commented Aug 5, 2024

I'm going to switch this plugin to work directly against the new tables using these new methods: https://docs.datasette.io/en/1.0a14/internals.html#getting-and-setting-metadata

@simonw
Copy link
Contributor Author

simonw commented Aug 5, 2024

Starting Datasette like this ensures even logged-out users can edit metadata

datasette --internal internal.db -s permissions.datasette-metadata-editable-edit true

@simonw
Copy link
Contributor Author

simonw commented Aug 6, 2024

This plugin won't need its own datasette_metadata_editable_entries table any more - it can use the Datasette core tables instead.

But... I might add an audit log table of some sort in order to let it record WHO edited the metadata and when.

@simonw
Copy link
Contributor Author

simonw commented Aug 6, 2024

I should probably add a migration which looks for an existing datasette_metadata_editable_entries table and copies values from it into the new metadata_* tables.

simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Got it working against new metadata tables, refs #7
c2ec4db 
Also added source_url and license_url, refs #3
@simonw simonw mentioned this issue Aug 6, 2024
Merged
simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Migration to upgrade previously stored edited metadata
c41a994 
Refs #7
simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Bump to datasette>=1.0a14
46e9c83 
This breaks the tests, as expected

Refs #7
simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Got it working against new metadata tables, refs #7
4c70a09 
Also added source_url and license_url, refs #3
simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Migration to upgrade previously stored edited metadata
1b84131 
Refs #7
@simonw
Copy link
Contributor Author

simonw commented Aug 6, 2024

I landed the PR.

@simonw simonw closed this as completed Aug 6, 2024
@simonw simonw mentioned this issue Aug 6, 2024
Closed
simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Remove schema.sql since that table is no longer used, refs #7
3b5b699
simonw added a commit that referenced this issue Aug 6, 2024
@simonw
Release 0.2a0
ff18b71 
Refs #3, #7, #8, #9, #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw