Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize() and enrich_batch() need access to datasette #16

Closed
simonw opened this issue Nov 17, 2023 · 0 comments
Closed

initialize() and enrich_batch() need access to datasette #16

simonw opened this issue Nov 17, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
First alpha

Comments

@simonw
Copy link
Collaborator

simonw commented Nov 17, 2023

If plugins are going to look up configuration (or secrets, as needed by datasette-enrichments-gpt) they need access to the datasette object. It should be passed to the initialize() and enrich_batch() methods.

Refs:
@simonw simonw added the enhancement New feature or request label Nov 17, 2023
simonw added a commit that referenced this issue Nov 17, 2023
@simonw
Added datasette argument, refs #16
e7e06c4
simonw added a commit to datasette/datasette-enrichments-jinja that referenced this issue Nov 17, 2023
@simonw
datasette argument
3c2808e 
Refs datasette/datasette-enrichments#16
simonw added a commit that referenced this issue Nov 17, 2023
@simonw
Release 0.1a3
33d0e4b 
Refs #16
simonw added a commit to datasette/datasette-enrichments-jinja that referenced this issue Nov 17, 2023
@simonw
datasette-enrichments>=0.1a3
577cbd2 
Refs datasette/datasette-enrichments#16
simonw added a commit that referenced this issue Nov 20, 2023
@simonw
Fix for config dict with strings vs lists, closes #18
211c2c6 
Also includes datasette fix from #16
@simonw simonw closed this as completed Nov 23, 2023
@simonw simonw added this to the First alpha milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
First alpha
Development

No branches or pull requests
1 participant
@simonw