This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Build different wheels for Python 2 and Python 3 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since recently we have different set of dependencies for Python 2 and Python 3 environments, hence we can't have one wheel because it may have only one set of dependencies and no way of conditional dependencies. So this commit removes "universal" wheels, which effectively means we will have two wheels: one for python2, and one for python3.
romankolpak
reviewed
Feb 26, 2018
| @@ -1,3 +1,10 @@ | |||
| 1.13.2 (2018 February 26) | |||
There was a problem hiding this comment.
are you planning to push a new release right after this is merged?
There was a problem hiding this comment.
Because currently we have only one wheel on PyPi (py2-py3 wheel), that's built by python3 and misses futures dependencies. Which means, it's impossible to install it on py2. :(
romankolpak
approved these changes
Feb 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recently we have different set of dependencies for Python 2 and
Python 3 environments, hence we can't have one wheel because it may have
only one set of dependencies and no way of conditional dependencies.
So this commit removes "universal" wheels, which effectively means we
will have two wheels: one for python2, and one for python3.