Get-DbaServerRoleMember - Fix Login parameter being overwritten #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tearing it UP! 🥳 |
potatoqualitee
approved these changes
Aug 18, 2022
|
Unfortunately, there are legitimate failures, so I'll wait to merge once tests pass |
|
I'm confused. The 3 failed tests on the changed command are the ones that weren't touched. 🤔 |
|
I figured it was a related failure? 🧐 |
|
My fault @potatoqualitee. All green 😄 |
|
ayyyy! tests, tests tests 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1)Purpose
When using more than one instance and the
-Loginparameter, the latter is overwritten and the filter won't work for the 2nd and subsequent instances on the collection of instances.Approach
Rename the variable that holds the final list of logins per instance.
Commands to test
Get-DbaServerRoleMember -SqlInstance "localhost:14333", "localhost:14334" -Login "sqladmin"
Screenshots
Before:
After:
Learning