Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pester V5 Instance Level Checks #882

Open
48 of 56 tasks
SQLDBAWithABeard opened this issue Apr 25, 2022 · 2 comments
Open
48 of 56 tasks

Add Pester V5 Instance Level Checks #882

SQLDBAWithABeard opened this issue Apr 25, 2022 · 2 comments
Labels
enhancement help wanted Performance Pester V5

Comments

@SQLDBAWithABeard
Copy link
Collaborator

SQLDBAWithABeard commented Apr 25, 2022 •
edited
Loading

Add new v5 checks using the initfields method to gather the information in the most efficient manner for each of the Instance Unique checks - Validating that the performance is improved and the results are the same as the v4 existing checks using the

https://github.com/dataplat/dbachecks/blob/pesterv5/Get-AllInstanceInfo%20testing.ps1 as an example

Here are the checks that use SpConfigure running in v5

pesterv5running.mp4

Invoke-DbcCheck Performance improvement running in v5 and with AllInstanceInfo Improvements

invokedbccheckperf.mp4

Improving AllInstanceInfo performance

allinstancinfo.mp4
  • AdHocDistributedQueriesEnabled
  • AdHocWorkload
  • ADUser
  • AgentServiceAdmin
  • BackupPathAccess
  • BuiltInAdmin
  • CLREnabled
  • CrossDBOwnershipChaining
  • DAC
  • DefaultBackupCompression
  • DefaultFilePath
  • DefaultTrace
  • EngineServiceAdmin
  • ErrorLog
  • ErrorLogCount
  • FullTextServiceAdmin
  • HideInstance
  • InstanceConnection
  • LatestBuild
  • LinkedServerConnection
  • LocalWindowsGroup
  • LoginAuditFailed
  • LoginAuditSuccessful
  • LoginCheckPolicy
  • LoginMustChange
  • LoginPasswordExpiration
  • MaxDopInstance
  • MaxMemory
  • MemoryDump
  • ModelDbGrowth
  • NetworkLatency
  • OLEAutomation
  • OLEAutomationProceduresDisabled
  • OrphanedFile
  • PublicPermission
  • RemoteAccessDisabled
  • SaDisabled
  • SaExist
  • SaRenamed
  • ScanForStartupProceduresDisabled
  • ServerNameMatch
  • SqlAgentProxiesNoPublicRole
  • SqlBrowserServiceAccount
  • SqlEngineServiceAccount
  • SQLMailXPsDisabled
  • SupportedBuild
  • SuspectPageLimit
  • TempDbConfiguration
  • TraceFlagsExpected
  • TraceFlagsNotExpected
  • TwoDigitYearCutoff
  • WhoIsActiveInstalled
  • XESessionRunning
  • XESessionRunningAllowed
  • XESessionStopped
  • XpCmdShellDisabled
@SQLDBAWithABeard
Copy link
Collaborator Author

SQLDBAWithABeard commented Apr 25, 2022 •
edited
Loading

Commits linked to this are

cf15b15
ac52c1b
c2bc5bb
fbbb81a
756d2ff

SQLDBAWithABeard added a commit that referenced this issue Apr 26, 2022
@SQLDBAWithABeard
New v5 AdHoc Tests #882
4464d38
SQLDBAWithABeard added a commit that referenced this issue Apr 26, 2022
@SQLDBAWithABeard
testing adhoc #882
11c1096
SQLDBAWithABeard added a commit that referenced this issue Apr 26, 2022
@SQLDBAWithABeard
AdHocDistributedQueriesEnabled v5 check and tests for perfs and valid…
f5ad707 
…ation #882
SQLDBAWithABeard added a commit that referenced this issue Apr 26, 2022
@SQLDBAWithABeard
Added DefaultFilePath checks and tested #882
78858b9
SQLDBAWithABeard added a commit that referenced this issue Apr 26, 2022
@SQLDBAWithABeard
added defaultfilepath checks and tested #882
0400d39
@jpomfret jpomfret mentioned this issue Apr 26, 2022
Open
48 tasks
@jpomfret jpomfret assigned jpomfret and unassigned jpomfret Apr 26, 2022
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
SaRenamed for v5 adn tested #882
b910e32
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
SaDisabled checks #882
52c70bc
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
saexist check adn testing #882
d8b71b9
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
DefaultBackupCompression checks added and tested #882
ba748b4
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
ModelDbGrowth check added and tested #882
c62535f
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
ErrorLogCount added and tested #882
b073c19
SQLDBAWithABeard added a commit that referenced this issue Apr 27, 2022
@SQLDBAWithABeard
MaxDopInstance added and tested #882
5706f31
@SQLDBAWithABeard
Copy link
Collaborator Author

dfea078

SQLDBAWithABeard added a commit that referenced this issue Apr 28, 2022
@SQLDBAWithABeard
TraceFlagsExpected add and tested #882
d24918a
SQLDBAWithABeard added a commit that referenced this issue Apr 28, 2022
@SQLDBAWithABeard
so that the old checks will match the new ones!! #882
89bb3de
SQLDBAWithABeard added a commit that referenced this issue May 16, 2022
@SQLDBAWithABeard
CLREnabled added and tested #882
a81ea5f
SQLDBAWithABeard added a commit that referenced this issue May 16, 2022
@SQLDBAWithABeard
whoisactive check added and tested #882
040f35f
SQLDBAWithABeard added a commit that referenced this issue May 16, 2022
@SQLDBAWithABeard
xpcmdshelldisabled added and tested #882
fe9427e
SQLDBAWithABeard added a commit that referenced this issue Jun 28, 2022
@SQLDBAWithABeard
something is peculiar in the containers #882
a440915
SQLDBAWithABeard added a commit that referenced this issue Jun 30, 2022
@SQLDBAWithABeard
lets add some xesssions running checks #882
b632323
SQLDBAWithABeard added a commit that referenced this issue Mar 28, 2023
@SQLDBAWithABeard
so we can check network latency #882
c11bfea
SQLDBAWithABeard added a commit that referenced this issue Mar 28, 2023
@SQLDBAWithABeard
so that we can test linked server connections #882
1a625b8
SQLDBAWithABeard added a commit that referenced this issue Mar 28, 2023
@SQLDBAWithABeard
so that we cna check max memory #882
196cad0
SQLDBAWithABeard added a commit that referenced this issue Mar 30, 2023
@SQLDBAWithABeard
so that we have orphanedfile checks #882
18319ae
SQLDBAWithABeard added a commit that referenced this issue Mar 30, 2023
@SQLDBAWithABeard
server name match should be checked #882
c2bc14a
SQLDBAWithABeard added a commit that referenced this issue Mar 30, 2023
@SQLDBAWithABeard
rob you fool, those are the wrong way around #882
c844c46
SQLDBAWithABeard added a commit that referenced this issue Mar 30, 2023
@SQLDBAWithABeard
so that we can check the orphaned files check correctly #882
7ac5f93
@SQLDBAWithABeard SQLDBAWithABeard mentioned this issue Mar 30, 2023
Merged
SQLDBAWithABeard added a commit that referenced this issue Apr 6, 2023
@SQLDBAWithABeard
so that we can check memory dumps #882
f262396
SQLDBAWithABeard added a commit that referenced this issue May 9, 2023
@SQLDBAWithABeard
just Tag Add Pester V5 Instance Level Checks #882
6ae50f2
SQLDBAWithABeard added a commit that referenced this issue May 9, 2023
@SQLDBAWithABeard
so we can check for hideinstance #882
434637d
SQLDBAWithABeard added a commit that referenced this issue May 9, 2023
@SQLDBAWithABeard
so we cna check login auditing #882
f916963
SQLDBAWithABeard added a commit that referenced this issue May 9, 2023
@SQLDBAWithABeard
so that we c nca check login check policy #882
b4e76a5
SQLDBAWithABeard added a commit that referenced this issue May 10, 2023
@SQLDBAWithABeard
so we can check supported buildand suspectpagelimit #882
be468ac
SQLDBAWithABeard added a commit that referenced this issue May 12, 2023
@SQLDBAWithABeard
needs to be the right reference #882
a46e6b2
SQLDBAWithABeard added a commit that referenced this issue May 12, 2023
@SQLDBAWithABeard
Merge pull request #973 from dataplat/instancecheckscontinued
d962e41 
Instancecheckscontinued more checks added #882
SQLDBAWithABeard added a commit that referenced this issue May 18, 2023
@SQLDBAWithABeard
so we cna check agent service admin #882
7f934ec
SQLDBAWithABeard added a commit that referenced this issue May 18, 2023
@SQLDBAWithABeard
so we can check the agent service accouunt for admin #882
4dd83f2
SQLDBAWithABeard added a commit that referenced this issue May 18, 2023
@SQLDBAWithABeard
so that we cna check the engline account #882
e30f598
SQLDBAWithABeard added a commit that referenced this issue Aug 3, 2023
@SQLDBAWithABeard
so that we cna check for public role permissions #882
1573d64
SQLDBAWithABeard added a commit that referenced this issue Aug 3, 2023
@SQLDBAWithABeard
so that we cna check for public role perms #882
3c0ad47
SQLDBAWithABeard added a commit that referenced this issue Aug 3, 2023
@SQLDBAWithABeard
yup #882
7b07e4d
SQLDBAWithABeard added a commit that referenced this issue Aug 16, 2023
@SQLDBAWithABeard
so that we can see failed connections and they are in the results #882
85229dc
SQLDBAWithABeard added a commit that referenced this issue Aug 16, 2023
@SQLDBAWithABeard
Merge pull request #995 from dataplat/instancecheckscontinued
10b7d26 
so that we can see failed connections and they are in the results #882
SQLDBAWithABeard added a commit that referenced this issue Aug 19, 2023
@SQLDBAWithABeard
so that the instance checks dont break Add Pester V5 Instance Level C…
aa3b2f5 
…hecks #882
SQLDBAWithABeard added a commit that referenced this issue Aug 26, 2023
@SQLDBAWithABeard
fixing stuff Add Pester V5 Instance Level Checks #882
7ec8934
SQLDBAWithABeard added a commit that referenced this issue Aug 26, 2023
@SQLDBAWithABeard
not tags Add Pester V5 Instance Level Checks #882
03f9d8d
SQLDBAWithABeard added a commit that referenced this issue Aug 26, 2023
@SQLDBAWithABeard
so we have list of not yet converted checks Add Pester V5 Instance Le…
3772dec 
…vel Checks #882
SQLDBAWithABeard added a commit that referenced this issue Aug 26, 2023
@SQLDBAWithABeard
so we exclude the not converted cheks and stop if only one Add Pester…
0d70a3c 
… V5 Instance Level Checks #882
SQLDBAWithABeard added a commit that referenced this issue Aug 26, 2023
@SQLDBAWithABeard
so that we dont have the additional output for v5 Add Pester V5 Insta…
fcab7db 
…nce Level Checks #882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Performance Pester V5
Projects
dbachecks - Pester V5 support and Performance improvements
Status: Doing
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpomfret @SQLDBAWithABeard