Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Seq 3.3, three and a half years ago, Seq has supported and been encouraging the use of the Serilog.Formatting.Compact "compact log event format" (CLEF) for ingestion.
It has the benefits of requiring less network bandwidth and storage space, being quicker to parse, and being supported by a variety of tools (e.g.
seqcli
,clef-tool
, Serilog.Formatting.Compact.Reader, and https://github.com/warrenbuckley/Compact-Log-Format-Viewer).While the sink has offered compact format as an option for some time, the older "raw" format was kept as the default for compatibility reasons. We could change the default and provide raw format as an option, but with the dwindling number of Seq 3.2 and earlier servers still in service, I think it's reasonable to pull out "raw" support altogether, and improve the overall maintainability of this codebase.
This PR removes
compact:
, and all of the underlying support for it, except for where it's necessary to ingest already-written durable file sets.