Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of values in the size control (indicator and table) #1899

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ import './DialogMetricSettings.scss';

const i18n = I18n.keyset('container.metric-dialog');

const SIZES = ['xl', 'l', 'm', 's'];
const SIZES = ['s', 'm', 'l', 'xl'];
const DEFAULT_SIZE = 'm';
const RADIO_TEXT = ['L', 'M', 'S', 'XS'];
const RADIO_TEXT = ['XS', 'S', 'M', 'L'];

const b = block('dialog-metric-settings');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ class DialogSettings extends React.PureComponent<InnerProps, State> {
return null;
}

const sizes = Object.values(WidgetSize);
const sizes = [WidgetSize.S, WidgetSize.M, WidgetSize.L];
const selected = this.state.size ?? DEFAULT_WIDGET_SIZE;

return (
Expand Down
Loading