Mass actions for datasets (Aggregations and change type)

src/i18n-keysets/dataset.dataset-editor.modify/en.json

@@ -2,10 +2,13 @@
   "button_add-field": "Add field",
   "button_apply": "Apply",
   "button_ask-access-rights": "Request permissions",
+  "button_batch-aggregation": "Change aggregation",
+  "button_batch-apply": "Apply",
   "button_batch-cancel": "Cancel",
   "button_batch-hide": "Hide",
   "button_batch-remove": "Delete",
   "button_batch-show": "Show",
+  "button_batch-type": "Change type",
   "button_copy-id": "Copy ID",
   "button_create": "Create",
   "button_create-widget": "Create chart",
@@ -35,7 +38,9 @@
   "column_title": "Name",
   "field_display-rows": "Number of rows:",
   "field_find-field": "Field name or description",
+  "label_batch-aggregation": "New field aggregation",
   "label_batch-selected-fields-count": "Fields selected — {{value}}",
+  "label_batch-type": "New field type",
   "label_column-field-id": "Field ID",
   "label_dataset-auto-creation-process": "Creating dataset",
   "label_display-fields-id": "Show field IDs",
@@ -57,12 +62,16 @@
   "label_preview-not-supported": "Preview is not available for this type of source",
   "label_request-dataset-preview-error": "Error: failed to upload data for preview",
   "section_preview": "Preview",
+  "text_batch-aggregation-alert": "<link>The aggregations available</link> depend on the selected field type",
+  "text_batch-aggregation-header": "Changing the field aggregation",
   "text_batch-hide-header": "Hide fields",
   "text_batch-hide-message": "Are you sure want to hide the selected fields?",
   "text_batch-remove-header": "Delete fields",
   "text_batch-remove-message": "Are you sure want to delete the selected fields?",
   "text_batch-show-header": "Show fields",
   "text_batch-show-message": "Are you sure want to show the selected fields?",
+  "text_batch-type-alert": "Some conversion types are not available",
+  "text_batch-type-header": "Changing the field type",
   "value_array_float": "Array of fractional numbers",
   "value_array_int": "Array of integers",
   "value_array_str": "Array of strings",

src/i18n-keysets/dataset.dataset-editor.modify/ru.json

@@ -2,10 +2,13 @@
   "button_add-field": "Добавить поле",
   "button_apply": "Применить",
   "button_ask-access-rights": "Запросить права",
+  "button_batch-aggregation": "Изменить агрегацию",
+  "button_batch-apply": "Изменить",
   "button_batch-cancel": "Отменить",
   "button_batch-hide": "Скрыть",
   "button_batch-remove": "Удалить",
   "button_batch-show": "Показать",
+  "button_batch-type": "Изменить тип",
   "button_copy-id": "Скопировать ID",
   "button_create": "Создать",
   "button_create-widget": "Создать чарт",
@@ -35,7 +38,9 @@
   "column_title": "Имя",
   "field_display-rows": "Количество строк:",
   "field_find-field": "Имя или описание поля",
+  "label_batch-aggregation": "Новая агрегация полей",
   "label_batch-selected-fields-count": "Выбрано полей — {{value}}",
+  "label_batch-type": "Новый тип полей",
   "label_column-field-id": "ID поля",
   "label_dataset-auto-creation-process": "Создаём датасет",
   "label_display-fields-id": "Отображать ID полей",
@@ -57,12 +62,16 @@
   "label_preview-not-supported": "Для данного типа источника предпросмотр не доступен",
   "label_request-dataset-preview-error": "Ошибка: не удалось загрузить данные для предпросмотра",
   "section_preview": "Предпросмотр",
+  "text_batch-aggregation-alert": "<link>Доступные агрегации</link> зависят от типа выбранных полей",
+  "text_batch-aggregation-header": "Изменение агрегации полей",
   "text_batch-hide-header": "Скрыть поля датасета",
   "text_batch-hide-message": "Вы уверены, что хотите скрыть выбранные поля датасета?",
   "text_batch-remove-header": "Удалить поля датасета",
   "text_batch-remove-message": "Вы уверены, что хотите удалить выбранные поля датасета?",
   "text_batch-show-header": "Показать поля датасета",
   "text_batch-show-message": "Вы уверены, что хотите показать выбранные поля датасета?",
+  "text_batch-type-alert": "Некоторые преобразования типов недоступны",
+  "text_batch-type-header": "Изменение типа полей",
   "value_array_float": "Массив дробных чисел",
   "value_array_int": "Массив целых чисел",
   "value_array_str": "Массив строк",

src/ui/components/DialogParameter/helpers.tsx

@@ -1,16 +1,12 @@
-import React from 'react';
-
 import type {SelectOption} from '@gravity-ui/uikit';
-import block from 'bem-cn-lite';
-import {i18n} from 'i18n';
-import type {DatasetField, WithRequired} from 'shared';
+import type {DatasetField} from 'shared';
 import {
     AVAILABLE_FIELD_TYPES,
     DATASET_FIELD_TYPES,
     DatasetFieldAggregation,
     DatasetFieldType,
 } from 'shared';
-import {DataTypeIcon} from 'ui';
+import {getTypeSelectOptions} from 'ui/utils/getTypeSelectOptions';
 
 import type {ParameterFormState} from './useParameterForm';
 
@@ -24,26 +20,10 @@ const NEW_PARAMETER_FIELD = {
     hidden: false,
 };
 
-const b = block('dialog-parameter');
-
 export const getTypesList = (): SelectOption[] => {
-    return AVAILABLE_FIELD_TYPES.map((type): WithRequired<SelectOption, 'text'> => {
-        const text = i18n('dataset.dataset-editor.modify', `value_${type}`);
-        return {
-            qa: `dialog-parameter-${type}`,
-            data: {
-                icon: <DataTypeIcon className={b('icon')} dataType={type as DATASET_FIELD_TYPES} />,
-            },
-            value: type,
-            content: text,
-            text,
-        };
-    }).sort((current, next) => {
-        const currentText = current.text;
-        const nextText = next.text;
+    const items = getTypeSelectOptions([...AVAILABLE_FIELD_TYPES]);
 
-        return currentText.localeCompare(nextText, undefined, {numeric: true});
-    });
+    return items.map((item) => ({...item, qa: `dialog-parameter-${item.value}`}));
 };
 
 export const createParameterField = (

src/ui/store/actions/openDialogTypes.ts

@@ -52,6 +52,7 @@ import type {OpenDialogDeleteWorkbookArgs} from '../../components/CollectionsStr
 import type {OpenDialogAddDemoWorkbookArgs} from '../../components/CollectionsStructure/AddDemoWorkbookDialog';
 import type {OpenDialogCreateEntryInWorkbookArgs} from '../../components/CollectionsStructure/CreateEntryInWorkbookDialog';
 import type {OpenDialogIamAccessArgs} from '../../components/IamAccessDialog';
+import type {OpenDialogChangeDatasetFieldsArgs} from '../../units/datasets/components/DatasetTable/components/BatchActionPanel/components/DialogChangeDatasetFields/DialogChangeDatasetFields';
 
 export type OpenDialogArgs<T = unknown> =
     | OpenDialogMetricSettingsArgs
@@ -105,4 +106,5 @@ export type OpenDialogArgs<T = unknown> =
     | OpenDialogDeleteWorkbookArgs
     | OpenDialogAddDemoWorkbookArgs
     | OpenDialogIamAccessArgs
-    | OpenDialogCreateEntryInWorkbookArgs;
+    | OpenDialogCreateEntryInWorkbookArgs
+    | OpenDialogChangeDatasetFieldsArgs;

src/ui/units/datasets/components/DatasetTable/DatasetTable.tsx

@@ -2,10 +2,11 @@ import React from 'react';
 
 import {ArrowDown, ArrowUp} from '@gravity-ui/icons';
 import DataTable from '@gravity-ui/react-data-table';
-import {Icon} from '@gravity-ui/uikit';
+import {Icon, Link} from '@gravity-ui/uikit';
 import block from 'bem-cn-lite';
 import {I18n} from 'i18n';
-import {get} from 'lodash';
+import get from 'lodash/get';
+import intersection from 'lodash/intersection';
 import type {
     DATASET_FIELD_TYPES,
     DatasetField,
@@ -16,6 +17,8 @@ import type {
     DatasetSourceAvatar,
 } from 'shared';
 import type {Permissions} from 'shared/types/dls';
+import {Interpolate} from 'ui/components/Interpolate';
+import {DL} from 'ui/constants';
 
 import type {
     OpenDialogConfirmArguments,
@@ -28,8 +31,11 @@ import {DIALOG_DS_FIELD_INSPECTOR} from '../dialogs';
 
 import {DisplaySettings} from './components';
 import {BatchActionPanel} from './components/BatchActionPanel/BatchActionPanel';
+import type {DialogChangeDatasetFieldsProps} from './components/BatchActionPanel/components/DialogChangeDatasetFields/DialogChangeDatasetFields';
+import {DIALOG_CHANGE_DATASET_FIELDS} from './components/BatchActionPanel/components/DialogChangeDatasetFields/DialogChangeDatasetFields';
 import {ObservedTableResizer} from './components/ObservedDataTable';
 import {BatchFieldAction, FieldAction} from './constants';
+import type {BatchUpdateFields, UpdatePayload} from './types';
 import {getAggregationSwitchTo, getColumns, isHiddenSupported} from './utils';
 
 import './DatasetTable.scss';
@@ -42,12 +48,6 @@ DataTable.setCustomIcons({
     ICON_DESC: <Icon className={b('sort-icon')} data={ArrowUp} />,
 });
 
-type UpdatePayload = {
-    debounce?: boolean;
-    validateEnabled?: boolean;
-    updatePreview?: boolean;
-};
-
 type DatasetTableProps = {
     options: DatasetOptions;
     fields: DatasetField[];
@@ -59,11 +59,7 @@ type DatasetTableProps = {
             field: Partial<DatasetField> & {new_id?: string};
         },
     ) => void;
-    batchUpdateFields: (
-        data: UpdatePayload & {
-            fields: Partial<DatasetField>[] & {new_id?: string}[];
-        },
-    ) => void;
+    batchUpdateFields: BatchUpdateFields;
     duplicateField: (data: {field: DatasetField}) => void;
     removeField: (data: {field: DatasetField}) => void;
     batchRemoveFields: (data: {fields: DatasetField[]}) => void;
@@ -117,6 +113,8 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
             map: selectedRows,
             canBeHidden,
             canBeShown,
+            allowedTypes,
+            allowedAggregations,
         } = this.getFilteredSelectedRows();
 
         return (
@@ -160,6 +158,8 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
                         disableActions={[
                             ...(canBeHidden.count > 0 ? [] : (['hide'] as const)),
                             ...(canBeShown.count > 0 ? [] : (['show'] as const)),
+                            ...(allowedTypes.length > 0 ? [] : (['type'] as const)),
+                            ...(allowedAggregations.length > 0 ? [] : (['aggregation'] as const)),
                         ]}
                     />
                 )}
@@ -169,7 +169,7 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
 
     private getFilteredSelectedRows() {
         const {selectedRows} = this.state;
-        const {fields} = this.props;
+        const {fields, options} = this.props;
 
         let count = 0;
         const canBeHidden: {count: number; fields: DatasetField[]} = {count: 0, fields: []};
@@ -200,7 +200,22 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
             return memo;
         }, {});
 
-        return {count, map, fields: filteredFields, canBeHidden, canBeShown};
+        const selectedItems = options.fields.items.filter(
+            (item) => this.state.selectedRows[item.guid],
+        );
+
+        const allowedTypes = intersection(...selectedItems.map((item) => item.casts));
+        const allowedAggregations = intersection(...selectedItems.map((item) => item.aggregations));
+
+        return {
+            count,
+            map,
+            fields: filteredFields,
+            canBeHidden,
+            canBeShown,
+            allowedTypes,
+            allowedAggregations,
+        };
     }
 
     private getColumns(selectedRows: DatasetSelectionMap = {}) {
@@ -248,6 +263,26 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
 
     private setActiveRow = (activeRow?: number) => this.setState({activeRow});
 
+    private batchChangeDialog = (
+        fields: DatasetField[],
+        props: Omit<
+            DialogChangeDatasetFieldsProps,
+            'open' | 'onClose' | 'fieldsGuids' | 'batchUpdateFields' | 'onApply'
+        >,
+    ) => {
+        this.props.openDialog({
+            id: DIALOG_CHANGE_DATASET_FIELDS,
+            props: {
+                open: true,
+                onClose: this.props.closeDialog,
+                fieldsGuids: fields.map(({guid}) => guid),
+                batchUpdateFields: this.props.batchUpdateFields,
+                onApply: this.resetSelection,
+                ...props,
+            },
+        });
+    };
+
     private batchConfirmDialog = (
         options: Partial<OpenDialogConfirmArguments> &
             Pick<
@@ -301,8 +336,49 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
         });
     };
 
+    private openBatchUpdateTypesDialog = (
+        fields: DatasetField[],
+        allowedTypes: DATASET_FIELD_TYPES[],
+    ) => {
+        this.batchChangeDialog(fields, {
+            warningMessage: i18n('text_batch-type-alert'),
+            title: i18n('text_batch-type-header'),
+            label: i18n('label_batch-type'),
+            types: allowedTypes,
+        });
+    };
+
+    private openBatchUpdateAggregationsDialog = (
+        fields: DatasetField[],
+        allowedAggregations: DatasetFieldAggregation[],
+    ) => {
+        this.batchChangeDialog(fields, {
+            warningMessage: (
+                <Interpolate
+                    text={i18n('text_batch-aggregation-alert')}
+                    matches={{
+                        link(match) {
+                            return (
+                                <Link
+                                    target="_blank"
+                                    href={`${DL.ENDPOINTS.datalensDocs}/dataset/data-model#aggregation`}
+                                >
+                                    {match}
+                                </Link>
+                            );
+                        },
+                    }}
+                ></Interpolate>
+            ),
+            title: i18n('text_batch-aggregation-header'),
+            label: i18n('label_batch-aggregation'),
+            aggregations: allowedAggregations,
+        });
+    };
+
     private handleBatchUpdate = (action: BatchFieldAction) => {
-        const {fields, canBeShown, canBeHidden} = this.getFilteredSelectedRows();
+        const {fields, canBeShown, canBeHidden, allowedTypes, allowedAggregations} =
+            this.getFilteredSelectedRows();
 
         switch (action) {
             case BatchFieldAction.Remove: {
@@ -320,6 +396,16 @@ class DatasetTable extends React.Component<DatasetTableProps, DatasetTableState>
                 return;
             }
 
+            case BatchFieldAction.Type: {
+                this.openBatchUpdateTypesDialog(fields, allowedTypes);
+                return;
+            }
+
+            case BatchFieldAction.Aggregation: {
+                this.openBatchUpdateAggregationsDialog(fields, allowedAggregations);
+                return;
+            }
+
             default: {
                 return;
             }

src/ui/units/datasets/components/DatasetTable/components/AggregationSelect/AggregationSelect.tsx

@@ -7,10 +7,9 @@ import {connect} from 'react-redux';
 import type {DatasetField, DatasetFieldAggregation} from 'shared';
 import type {DatalensGlobalState} from 'ui';
 
-import {getSelectedValueForSelect} from '../../../../../../utils/helpers';
+import {getDatasetLabelValue, getSelectedValueForSelect} from '../../../../../../utils/helpers';
 import {AGGREGATION_AUTO, AGGREGATION_NONE} from '../../../../constants';
 import {datasetValidationSelector} from '../../../../store/selectors/dataset';
-import {getLabelValue} from '../../utils';
 
 import './AggregationSelect.scss';
 
@@ -65,7 +64,7 @@ class AggregationSelectComponent extends React.Component<Props> {
 
                 return {
                     value: aggregation,
-                    content: getLabelValue(aggregationTitle),
+                    content: getDatasetLabelValue(aggregationTitle),
                     disabled: validation.isLoading,
                 };
             })
@@ -139,7 +138,9 @@ class AggregationSelectComponent extends React.Component<Props> {
                 view="flat"
                 className={b('select-control', {[this.type]: true})}
             >
-                <span className={b('selected-value')}>{getLabelValue(aggregationTitle)}</span>
+                <span className={b('selected-value')}>
+                    {getDatasetLabelValue(aggregationTitle)}
+                </span>
             </Button>
         );
     };