fix(datasets): BI-5245 fix source refresh with deleted fields, do not force refresh always #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantAnxiety
changed the title
KonstantAnxiety
commented
Sep 11, 2024
| return [ | ||
| field | ||
| for field in self.fields | ||
| if isinstance(field.calc_spec, DirectCalculationSpec) and field.source == source_id |
There was a problem hiding this comment.
Classic naming issue: there are db sources (e.g. database table) and dataset sources (Dataset -> DataSource), which wrap db sources
field.source is the table name, it can't be equal to the source_id (which is a dataset source id), so this method has been returning an empty array all this time
… force refresh always
KonstantAnxiety
force-pushed
the
konstasa/refresh-source-no-force
branch
from
5ad3533 to
06ac1da
Compare
ovsds
approved these changes
Oct 4, 2024
KonstantAnxiety
added
component/datasets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Therefore speed up dataset validation in some cases