Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix v0.2069.1 #405

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Hotfix v0.2069.1 #405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/dl_connector_clickhouse/dl_connector_clickhouse/core/clickhouse_base/ch_commons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def get_ch_settings(
# forever-running queries (which is also known to break old-version CH
# hosts at around 100_000 second long queries).
# Note that in CH the value is rounded down to integer, and 0 seems to mean 'no limit'.
"max_execution_time": max_execution_time if max_execution_time is not None else 3600 * 4,
# TODO: get rid of this parameter or figure out a proper way to use it, bc CH's estimates seem to be way off
"max_execution_time": max_execution_time if max_execution_time is None else 3600 * 4,
"readonly": read_only_level,
# https://clickhouse.com/docs/en/operations/settings/settings#settings-insert_quorum
# INSERT succeeds only when ClickHouse manages to correctly write data to the insert_quorum
Expand Down
Loading