Patch scp argument-building in BaseSSHConnection
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 97.20% 97.23% +0.02%
==========================================
Files 15 16 +1
Lines 286 325 +39
==========================================
+ Hits 278 316 +38
- Misses 8 9 +1
☔ View full report in Codecov by Sentry. |
This commit contains a patch that modifies the scp-target generation code in BaseSSHConnector. The core-code did not support the specification of user-IDs.
christian-monch
force-pushed
the
fix-scp-args
branch
from
32fa04c
to
2a4ca09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a patch for
datalad.support.sshconnector.BaseSSHConnection.getanddatalad.support.sshconnector.BaseSSHConnection.put. The original code excluded user definitions from the target arguments.