Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'populated_dataset' fixture as alternative to 'populate_dataset' helper #67

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

adswa
Copy link
Member

@adswa adswa commented Sep 13, 2023

fixes #64

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20% 🎉

Comparison is base (8b76391) 96.93% compared to head (c804f5d) 97.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   96.93%   97.14%   +0.20%     
==========================================
  Files          15       15              
  Lines         196      210      +14     
==========================================
+ Hits          190      204      +14     
  Misses          6        6              
Files Changed Coverage Δ
datalad_ria/conftest.py 100.00% <ø> (ø)
datalad_ria/tests/fixtures.py 97.61% <100.00%> (+0.47%) ⬆️
datalad_ria/tests/test_fixtures.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…om prev. ria_utils

import populated_dataset fixture in conftest

TST: add a brief test for populated_dataset fixture
@adswa
Copy link
Member Author

adswa commented Sep 21, 2023

any objections to this PR?

@jsheunis
Copy link
Member

No from my side

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx!

@adswa adswa merged commit 2fa07f7 into main Sep 21, 2023
3 checks passed
@adswa adswa deleted the fixture-tree branch September 21, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement fixture for a populated test dataset
4 participants