New ria_sshserver fixture #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adswa
reviewed
Sep 13, 2023
adswa
reviewed
Sep 13, 2023
This should be easier to use. The old implementation is now available in `ria_sshserver_setup` and should be considered internal. The new fixture returns the base RIA URL, and a local path to that same root directory (if one exists). It also sets `DATALAD_SSH_IDENTITYFILE`, which is needed by datalad-core's `SSHManager`. The setup may still need to use the `datalad_cfg` fixture, and possibly a dedicated reload to be effective. Closes #60
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 98.07% 97.60% -0.48%
==========================================
Files 7 9 +2
Lines 104 125 +21
==========================================
+ Hits 102 122 +20
- Misses 2 3 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be easier to use. The old implementation is now available in
ria_sshserver_setupand should be considered internal.The new fixture returns the base RIA URL, and a local path to that same
root directory (if one exists).
It also sets
DATALAD_SSH_IDENTITYFILE, which is needed by datalad-core'sSSHManager. The setup may still need to use thedatalad_cfgfixture, and possibly a dedicated reload to be effective.Closes #60