Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHRemoteIO.remove_dir() does not error on error #82

Closed
mih opened this issue Sep 21, 2023 · 1 comment · Fixed by #92
Closed

SSHRemoteIO.remove_dir() does not error on error #82

mih opened this issue Sep 21, 2023 · 1 comment · Fixed by #92

Comments

@mih
Copy link
Member

mih commented Sep 21, 2023

A test that documents that behavior is available from #81

@mih
Copy link
Member Author

mih commented Sep 21, 2023

FileIO.remove_dir() is using Path.rmdir() which also errors:

>>> (p / 'mike').rmdir()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.11/pathlib.py", line 1157, in rmdir
    os.rmdir(self)
OSError: [Errno 39] Directory not empty: 'mike'

mih added a commit that referenced this issue Sep 21, 2023
This aligns its behavior with `FileIO.remove_dir()`.

Closes #82
mih added a commit that referenced this issue Sep 21, 2023
This aligns its behavior with `FileIO.remove_dir()`.

Closes #82
@mih mih closed this as completed in #92 Sep 21, 2023
mih added a commit that referenced this issue Sep 21, 2023
This aligns its behavior with `FileIO.remove_dir()`.

Closes #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant