Switch datalad-annex:: to use git-annex plumbing 'transferkey'
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the complications with changing behavior of `git-annex-fsck` with 10.20220525 (see #72). Moreover, it allows for moving to an opportunistic download that just tries, instead of having to check with the remote first. This safes a request, and should translate to measurable speed-up for slow remotes (e.g. WebDAV). Closes #75
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 80.27% 86.68% +6.41%
==========================================
Files 27 27
Lines 2104 2381 +277
==========================================
+ Hits 1689 2064 +375
+ Misses 415 317 -98
Continue to review full report at Codecov.
|
mslw
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
If I understand correctly:
- in git-annex > 10.20220504 breaks
git-clonefromdatalad-annex::...exporttree=yes(any special remote type) #72, thegit-annex-checkpresentkeycommand (docs) was suggested as a more suitable replacement forgit-annex-fsck - but since this is always followed by
git-annex-get, the two can be replaced with a singlegit-annex-transferkey(docs); errors of which are handled in the case of missing keys - the PR does just that
I didn't know any of these things before, but looking at the docs and the diff, this seems clear-cut to me.
|
Thanks a lot for getting to the bottom of the issue @mih! Given that there's 2 reviews and checks pass I'd merge right away, but I don't have write access to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the complications with changing behavior of
git-annex-fsckwith 10.20220525 (see
#72). Moreover, it allows
for moving to an opportunistic download that just tries, instead of
having to check with the remote first. This saves a request, and should
translate to measurable speed-up for slow remotes (e.g. WebDAV).
Closes #75