Add support for pathspecs to iter_gitdiff()
#747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is anticipating the implementation of a pathspec enabled reporting pattern that follows the model of `iter_gitworktree`.
When adding pathspec support, we need to be able to collect information which submodules have already been reported on. This is best done in a lean wrapper, and this change is preparing for that.
The implementation largely follows the pattern used in `iter_gitworktree()`. It concludes a series of refactoring that aligned both implementations. A top-level helper is monitored for reports on submodules. If pathspecs are giving, an additional query, unconstrained by pathspecs, is made to discover any submodules modified. For each such submodule, the given pathspecs are ported to the scope of the submodule, and if matching, a pathspec-constrained is generated for that submodule too. In this fashion, `iter_gitdiff()` can report on pathspec-constrained matches, where the constrained does not necessarily match the submodule root.
…em.name` is a `str`
…pe-checker And people ...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
=======================================
Coverage ? 92.32%
=======================================
Files ? 185
Lines ? 14184
Branches ? 2129
=======================================
Hits ? 13095
Misses ? 821
Partials ? 268 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #598