Introduce early check for submodule presence in status evaluation #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can dramatically boost performance with many submodules. Checking the filesystem for a file is much cheaper than running `git rev-parse`. When a subdataset is present, this obviously means an additional cost. However, in comparison to the then following state evaluation, it should still be cheap. Worth it, IMHO. Closes: datalad#606
This is less about performance (marginal improvement), but simply code complexity. In the present case we never expect more than two lines of (short) output.
Now matches the actual expectations of the function
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
==========================================
- Coverage 92.99% 92.94% -0.06%
==========================================
Files 159 159
Lines 11852 11853 +1
Branches 1794 1794
==========================================
- Hits 11022 11017 -5
- Misses 644 648 +4
- Partials 186 188 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can dramatically boost performance with many submodules. Checking
the filesystem for a file is much cheaper than running
git rev-parse.When a subdataset is present, this obviously means an additional cost.
However, in comparison to the then following state evaluation, it should
still be cheap.
Worth it, IMHO.
Closes: #606