Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests when ran as root #593

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Skip tests when ran as root #593

merged 1 commit into from
Jan 12, 2024

Conversation

adswa
Copy link
Member

@adswa adswa commented Jan 12, 2024

There were a handful of tests reported in #525 that failed when ran as root. This PR implements the proposed solution to skip these tests when ran as root, using a preexisting pytest util from datalad-core.

fixes #525

fixes datalad#525, using a pytest util from datalad-core
@adswa adswa requested a review from mih as a code owner January 12, 2024 10:09
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97b373c) 92.44% compared to head (98ac8a8) 92.59%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
+ Coverage   92.44%   92.59%   +0.15%     
==========================================
  Files         149      151       +2     
  Lines       10783    11119     +336     
  Branches     1617     1653      +36     
==========================================
+ Hits         9968    10296     +328     
- Misses        638      642       +4     
- Partials      177      181       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this issue! The approach makes sense.

@mih mih merged commit 6859d05 into datalad:main Jan 12, 2024
7 checks passed
@mih mih added this to the 1.1 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests run as root fail
2 participants