Let iter_gitworktree(fp=True) report on symlinked content
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This generalizes an approach from datalad#539. It is implemented in a way that enables reuse of the helpers in that PR too. With this change regular files (tracked or untracked) and symlink targets (via the symlink) are also opened, if they actually exist. Closes datalad#553
Guidelines from datalad@319a07d
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 92.71% 92.73% +0.02%
==========================================
Files 137 137
Lines 10113 10157 +44
Branches 1093 1103 +10
==========================================
+ Hits 9376 9419 +43
- Misses 713 714 +1
Partials 24 24 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes an approach from
#539. It is implemented in a way that enables reuse of the helpers in that PR too.
With this change regular files (tracked or untracked) and symlink targets (via the symlink) are also opened, if they actually exist.
Closes #553