Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotations in datalad_next/itertools/itemize.py #550

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

christian-monch
Copy link
Contributor

Fixes issue #549

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4cf164b) 92.66% compared to head (70225c4) 92.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         137      137           
  Lines       10053    10054    +1     
  Branches     1087     1087           
=======================================
+ Hits         9316     9317    +1     
  Misses        713      713           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit fixes the `mypy`-errors
described in issue
datalad#549
This commit modifies the docstrings
to better match the type annotations.
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mih mih merged commit 39204d3 into datalad:main Nov 28, 2023
9 checks passed
@mih mih added this to the 1.1 milestone Dec 6, 2023
@christian-monch christian-monch deleted the issue-549-mypy-errors-in-itemize branch July 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants